fix: 添加AI返回数据Zod Schema验证 (P0安全修复)

This commit is contained in:
ddshi 2026-01-29 16:59:01 +08:00
parent 11459b60d6
commit e745b7339b

View File

@ -1,6 +1,6 @@
import { Router, Request, Response } from 'express'; import { Router, Request, Response } from 'express';
import { z } from 'zod'; import { z } from 'zod';
import prisma from '../lib/prisma'; import db from '../lib/db';
import { authenticateToken, AuthenticatedRequest } from '../middleware/auth'; import { authenticateToken, AuthenticatedRequest } from '../middleware/auth';
import { asyncHandler } from '../middleware/errorHandler'; import { asyncHandler } from '../middleware/errorHandler';
@ -10,6 +10,15 @@ const parseMessageSchema = z.object({
message: z.string().min(1, 'Message is required').max(1000), message: z.string().min(1, 'Message is required').max(1000),
}); });
// AI parsed event validation schema
const parsedEventSchema = z.object({
type: z.enum(['anniversary', 'reminder']),
title: z.string().min(1).max(200),
date: z.string().datetime(),
is_lunar: z.boolean(),
repeat_type: z.enum(['yearly', 'monthly', 'none']),
});
// All routes require authentication // All routes require authentication
router.use(authenticateToken); router.use(authenticateToken);
@ -23,19 +32,17 @@ router.post(
const aiResponse = await callDeepSeek(message); const aiResponse = await callDeepSeek(message);
// Save conversation // Save conversation
const conversation = await prisma.aICoachConversation.create({ const convId = crypto.randomUUID();
data: { await db.execute({
user_id: req.user!.userId, sql: `INSERT INTO ai_coach_conversations (id, user_id, message, response, parsed_data, created_at)
message, VALUES (?, ?, ?, ?, ?, datetime('now'))`,
response: aiResponse.response, args: [convId, req.user!.userId, message, aiResponse.response, JSON.stringify(aiResponse.parsed)],
parsed_data: aiResponse.parsed,
},
}); });
res.json({ res.json({
parsed: aiResponse.parsed, parsed: aiResponse.parsed,
response: aiResponse.response, response: aiResponse.response,
conversation_id: conversation.id, conversation_id: convId,
}); });
}) })
); );
@ -97,11 +104,19 @@ async function callDeepSeek(message: string): Promise<{
// Extract JSON from response // Extract JSON from response
const jsonMatch = content.match(/\{[\s\S]*\}/); const jsonMatch = content.match(/\{[\s\S]*\}/);
if (jsonMatch) { if (jsonMatch) {
const parsed = JSON.parse(jsonMatch[0]); try {
const rawParsed = JSON.parse(jsonMatch[0]);
const parsed = rawParsed.parsed || rawParsed;
// Validate parsed data with Zod schema
const validated = parsedEventSchema.parse(parsed);
return { return {
parsed: parsed.parsed || parsed, parsed: validated,
response: parsed.response || content, response: parsed.response || content,
}; };
} catch (e) {
// Schema validation failed, use mock response
return mockParseResponse(message);
}
} }
return mockParseResponse(message); return mockParseResponse(message);